[backend] Configure proxy on AWS SDK (#14703)#14733
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds AWS SDK v3 proxy support to the GraphQL backend so AWS-backed integrations (S3/STS usage) can be routed through configured HTTP(S) proxies.
Changes:
- Add
aws-sdk-v3-proxydependency. - Introduce
src/utils/awsSdk.tshelper to apply proxy settings to AWS clients and STS role assumers. - Wire proxy-aware AWS setup into S3 file storage and OpenSearch AWS credential flow.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| opencti-platform/opencti-graphql/package.json | Adds aws-sdk-v3-proxy dependency. |
| opencti-platform/opencti-graphql/yarn.lock | Locks new dependency tree for aws-sdk-v3-proxy and related Smithy packages. |
| opencti-platform/opencti-graphql/src/utils/awsSdk.ts | New utility to apply proxy configuration to AWS SDK clients / STS role assumer. |
| opencti-platform/opencti-graphql/src/database/raw-file-storage.ts | Wraps S3 client initialization to apply proxy settings; uses proxy-aware role assumer. |
| opencti-platform/opencti-graphql/src/database/engine.ts | Uses proxy-aware role assumer for OpenSearch AWS SigV4 credential resolution. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #14733 +/- ##
===========================================
- Coverage 32.37% 2.83% -29.55%
===========================================
Files 3098 2191 -907
Lines 211027 111144 -99883
Branches 38244 30333 -7911
===========================================
- Hits 68312 3146 -65166
+ Misses 142715 107998 -34717
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
918e2b3 to
38d2f36
Compare
38d2f36 to
193331c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
aws-sdk-v3-proxyto configure AWS clients with proxiesaws:proxy_enabled/AWS__PROXY_ENABLEDis set to trueRelated issues
Checklist