Skip to content

feat: update PHP and Magento framework requirements in composer.json #155#156

Draft
dermatz wants to merge 1 commit intomainfrom
feat/#155/composer-contraints
Draft

feat: update PHP and Magento framework requirements in composer.json #155#156
dermatz wants to merge 1 commit intomainfrom
feat/#155/composer-contraints

Conversation

@dermatz
Copy link
Copy Markdown
Member

@dermatz dermatz commented Apr 8, 2026

This pull request for Issue #155 updates the package requirements in composer.json to ensure compatibility with newer versions of PHP and Magento.

Dependency updates:

  • Updated the required PHP version to >=8.3 to ensure the project runs on PHP 8.3 or higher.
  • Updated the required magento/framework version to >=103.0.7 for improved compatibility and security.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates MageForge’s Composer platform/dependency constraints to formalize the minimum supported PHP and Magento Framework versions, aligning with Issue #155’s request for explicit compatibility requirements.

Changes:

  • Add a PHP version requirement (php) in composer.json.
  • Add a Magento Framework requirement (magento/framework) in composer.json.

}
},
"require": {
"php": ">=8.3",
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constraint php: ">=8.3" is very permissive and would also allow PHP 9.x once it exists, which may break this module without warning. Consider constraining the upper bound (e.g., ^8.3 or >=8.3 <9.0) to express the intended compatibility range more accurately.

Suggested change
"php": ">=8.3",
"php": "^8.3",

Copilot uses AI. Check for mistakes.
},
"require": {
"php": ">=8.3",
"magento/framework": ">=103.0.7",
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, magento/framework: ">=103.0.7" allows future major framework versions (e.g., 104.x) that may not be compatible with this module. To avoid Composer selecting untested major versions, constrain this to the intended major line (e.g., ^103.0.7 or >=103.0.7 <104.0).

Suggested change
"magento/framework": ">=103.0.7",
"magento/framework": "^103.0.7",

Copilot uses AI. Check for mistakes.
@dermatz dermatz marked this pull request as draft April 8, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants