feat: update PHP and Magento framework requirements in composer.json #155#156
feat: update PHP and Magento framework requirements in composer.json #155#156
Conversation
There was a problem hiding this comment.
Pull request overview
Updates MageForge’s Composer platform/dependency constraints to formalize the minimum supported PHP and Magento Framework versions, aligning with Issue #155’s request for explicit compatibility requirements.
Changes:
- Add a PHP version requirement (
php) incomposer.json. - Add a Magento Framework requirement (
magento/framework) incomposer.json.
| } | ||
| }, | ||
| "require": { | ||
| "php": ">=8.3", |
There was a problem hiding this comment.
The constraint php: ">=8.3" is very permissive and would also allow PHP 9.x once it exists, which may break this module without warning. Consider constraining the upper bound (e.g., ^8.3 or >=8.3 <9.0) to express the intended compatibility range more accurately.
| "php": ">=8.3", | |
| "php": "^8.3", |
| }, | ||
| "require": { | ||
| "php": ">=8.3", | ||
| "magento/framework": ">=103.0.7", |
There was a problem hiding this comment.
Similarly, magento/framework: ">=103.0.7" allows future major framework versions (e.g., 104.x) that may not be compatible with this module. To avoid Composer selecting untested major versions, constrain this to the intended major line (e.g., ^103.0.7 or >=103.0.7 <104.0).
| "magento/framework": ">=103.0.7", | |
| "magento/framework": "^103.0.7", |
This pull request for Issue #155 updates the package requirements in
composer.jsonto ensure compatibility with newer versions of PHP and Magento.Dependency updates:
>=8.3to ensure the project runs on PHP 8.3 or higher.magento/frameworkversion to>=103.0.7for improved compatibility and security.