This repository was archived by the owner on Mar 3, 2026. It is now read-only.
Address code review findings: remove unreachable code and fix style issues#57
Merged
Morgy93 merged 2 commits intofix-code-scanningfrom Jan 12, 2026
Merged
Address code review findings: remove unreachable code and fix style issues#57Morgy93 merged 2 commits intofix-code-scanningfrom
Morgy93 merged 2 commits intofix-code-scanningfrom
Conversation
Merged
…nd clean up imports Co-authored-by: Morgy93 <7961978+Morgy93@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix code scanning issues
Address code review findings: remove unreachable code and fix style issues
Jan 12, 2026
Morgy93
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses four code review findings from PR #56: unreachable return statement, inconsistent comment indentation, and non-idiomatic module imports in tests.
Changes:
Remove unreachable code in
ddev-utils.ts:218: Thereturn result.stdout;statement was dead code—whenresult.status === 0, execution returns earlier via theallowedExitCodescheck (line 203); whenresult.status !== 0, an error is thrown (line 215).Fix comment indentation in
ddev-utils.ts: Removed extra leading spaces from comments at lines 207 and 220 to align with surrounding code.Modernize imports in
ddev-utils.test.ts: Replacedrequire()calls forchild_processandfswith ES6 imports, eliminating the need for runtimerequirestatements inbeforeEach.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.