This repository was archived by the owner on Mar 3, 2026. It is now read-only.
Handle null status in isDdevRunning and use separate args for PHPStan options#58
Merged
Morgy93 merged 2 commits intofix-code-scanningfrom Jan 12, 2026
Merged
Handle null status in isDdevRunning and use separate args for PHPStan options#58Morgy93 merged 2 commits intofix-code-scanningfrom
Morgy93 merged 2 commits intofix-code-scanningfrom
Conversation
Merged
…n options Co-authored-by: Morgy93 <7961978+Morgy93@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code scanning issues
Handle null status in isDdevRunning and use separate args for PHPStan options
Jan 12, 2026
Morgy93
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback from PR #56 to improve error handling and command argument consistency.
Error handling in
isDdevRunning:result.errorandresult.status === nullto distinguish between "ddev not running" vs "ddev command not found/failed" scenariosPHPStan command building:
--level=${value}and--exclude=${path}to separate arguments:'--level', valueand'--exclude', path💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.