Repository navigation
Fix race in batch timeout observer test - #223
Merged
vharseko merged 1 commit intoNov 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BatchApiOpImplTest.testExecuteBatchFailsWhenNoTokenArrivesintermittently fails because it checks the observer immediately afterexecuteBatchthrows. The promise wakes its waiting caller before invoking exception listeners, soobserver.onErrormay not have recorded the error yet.The recording observer now signals a
CountDownLatchafter storing the error, and the test waits up to five seconds before checking it. The existing checks for the exception type, operation duration, and absence ofonCompletedremain in place.Observed failure: macOS / Java 27 build.
Validation:
onErrorby 250 ms: the original test failed with the CI assertion; the fixed test passed. The delay is not part of this change.mvn -o -B -pl OpenICF-java-framework/connector-framework-server -am package -Dmaven.javadoc.skip=truesucceeded: 789 tests, zero failures or errors, two skipped; all 33 server-module tests passed.git diff --checkpassed.