Skip to content

add missing docs - #73

Closed
maximthomas wants to merge 1866 commits into
OpenIdentityPlatform:masterfrom
maximthomas:features/add-missing-docs
Closed

maximthomas wants to merge 1866 commits into
OpenIdentityPlatform:masterfrom
maximthomas:features/add-missing-docs

Conversation

@maximthomas

Copy link
Copy Markdown
Contributor

No description provided.

vharseko and others added 25 commits July 12, 2023 19:36
…tityPlatform#57)

Bumps org.apache.ivy:ivy from 2.5.1 to 2.5.2.

---
updated-dependencies:
- dependency-name: org.apache.ivy:ivy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…yPlatform#58)

Bumps org.apache.zookeeper:zookeeper from 3.5.10 to 3.7.2.

---
updated-dependencies:
- dependency-name: org.apache.zookeeper:zookeeper
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…tyPlatform#63)

Bumps [ch.qos.logback:logback-classic](https://github.com/qos-ch/logback) from 1.2.11 to 1.2.13.
- [Commits](qos-ch/logback@v_1.2.11...v_1.2.13)

---
updated-dependencies:
- dependency-name: ch.qos.logback:logback-classic
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@maximthomas
maximthomas requested a review from vharseko July 2, 2024 09:55
@maximthomas maximthomas closed this Jul 2, 2024
@maximthomas
maximthomas deleted the features/add-missing-docs branch July 2, 2024 10:25
vharseko added a commit that referenced this pull request Oct 22, 2026
…st actions (#170)

Closes the 16 open `medium` code scanning alerts in `.github/workflows`
(`actions/missing-workflow-permissions` #70–#73, #85 and
`actions/unpinned-tag` #74–#84).

### Explicit `GITHUB_TOKEN` permissions

| Workflow / job | Needs | `permissions` |
|---|---|---|
| `build.yml` (workflow-level) | checkout, artifacts, push to
`localhost:5000` | `contents: read` |
| `release.yml` / `release-maven` | `mvn release:prepare` pushes commits
+ tag, `action-gh-release`, wiki push | `contents: write` |
| `release.yml` / `release-docker` | checkout, `docker/login-action` to
GHCR with `GITHUB_TOKEN` | `contents: read`, `packages: write` |
| `deploy.yml` / `deploy-maven` | checkout, wiki push (OSSRH and doc
site use their own secrets/PAT) | `contents: write` |

### Third-party actions pinned to commit SHAs

`docker/metadata-action` v6.2.0, `docker/setup-qemu-action` v4.4.0,
`docker/setup-buildx-action` v4.4.1, `docker/login-action` v4.6.0,
`docker/build-push-action` v7.4.0, `softprops/action-gh-release` v3.0.3
— each as `@<sha> # vX.Y.Z`. `actions/*` and `github/codeql-action` stay
on major tags (first-party, not flagged by CodeQL).

### Actions updated to the latest releases

- `actions/checkout` v6 → v7
- `actions/setup-java` v5 → v6
- `actions/cache` v5 → v6
- `softprops/action-gh-release` v2 → v3.0.3 (Node 24 runtime)

Release notes checked for breaking changes: checkout v7 only blocks
fork-PR checkouts under `pull_request_target`/`workflow_run` (our
`deploy.yml` job only runs for `push` events of the base repo); cache v6
is an ESM migration with no input changes. setup-java v6 renames
`server-username` / `server-password` to `server-username-env-var` /
`server-password-env-var` and keeps the old names only as deprecated
aliases that log a warning on every run, so `release.yml` and
`deploy.yml` switch to the new inputs (the generated `settings.xml` is
unchanged: `${env.MAVEN_USERNAME}` / `${env.MAVEN_PASSWORD}`).

### `.github/dependabot.yml`

New: `github-actions` ecosystem, weekly, all action updates grouped into
a single PR with labels `ci` + `dependencies`. Dependabot updates the
pinned SHA and the `# vX.Y.Z` comment together, so the pins do not go
stale.

### License headers

- `.github/dependabot.yml` — new file, CDDL header with `Copyright 2026
3A Systems, LLC.`
- `.github/workflows/build.yml`, `deploy.yml`, `release.yml` — CDDL
header added with `Portions Copyright 2026 3A Systems, LLC.`

### Note for the reviewer

The `permissions` blocks for `release.yml` and `deploy.yml` can only be
fully validated by a real release / deploy run. The wiki and doc-site
steps are `continue-on-error: true`, so a missing permission there would
not fail the workflow but would silently skip the publish — worth a
glance at the logs of the first run after merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants