Do not rely on std::endl function address and fix warnings#24
Merged
psi29a merged 3 commits intoOpenMW:3.6from Mar 2, 2024
Merged
Do not rely on std::endl function address and fix warnings#24psi29a merged 3 commits intoOpenMW:3.6from
psi29a merged 3 commits intoOpenMW:3.6from
Conversation
include/osg/Plane:244:17: warning: variable 'noOn' set but not used [-Wunused-but-set-variable]
int noOn = 0;
^
include/osg/Plane:273:17: warning: variable 'noOn' set but not used [-Wunused-but-set-variable]
int noOn = 0;
^
Relying on the address of std::endl is a std library specific behaviour. For example in libc++ it's inline function so it may have many addresses depending on the translation unit. This leads to different behaviour of osg::Node serialization using osgDB::ReaderWriter for osgt format.
elsid
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relying on the address of
std::endlis a std library specific behaviour. For example in libc++ it's inline function so it may have many addresses depending on the translation unit. Basically this code from theisEndlfunction does not work as you could expect. In different translation units it will be evaluated into true or false which makes this function unpredictable and leads to broken behaviour. For example to failed tests in openmw which compare serializedosg::Nodeintoosgtformat.