Open
Conversation
corporate-gadfly
requested changes
Jan 6, 2026
ekohl
force-pushed
the
avoid-open-to-exec
branch
3 times, most recently
from
6f1ca15 to
7d9a6e0
Compare
Contributor
Author
|
I know this is incomplete and some tests still fail, but it's a start. |
RuboCop rightfully complains about using open() to spawn a process. This uses the way simpler IO.popen() method.
ekohl
force-pushed
the
avoid-open-to-exec
branch
from
7d9a6e0 to
fd54e75
Compare
Contributor
|
I pushed your branch to the OpenVoxProject repo, so I can kick off the build action: https://github.com/OpenVoxProject/openvox/actions/runs/21248923654 |
ekohl
commented
Jan 22, 2026
| raise Puppet::ExecutionFailure, output if failonfail | ||
| end | ||
|
|
||
| if failonfail && exitstatus != 0 |
Contributor
Author
There was a problem hiding this comment.
Note to self: I don't know if exitstatus is properly set here. https://rubyapi.org/3.4/o/io#method-c-popen doesn't mention setting $CHILD_STATUS, only $?.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RuboCop rightfully complains about using open() to spawn a process. This uses the way simpler IO.popen() method.
I have no idea if this is going to break or not and whether it's an API breakage.