Skip to content

CI: run rubocop only once#87

Merged
bastelfreak merged 1 commit into
OpenVoxProject:mainfrom
bastelfreak:rubocop2
May 8, 2026
Merged

CI: run rubocop only once#87
bastelfreak merged 1 commit into
OpenVoxProject:mainfrom
bastelfreak:rubocop2

Conversation

@bastelfreak
Copy link
Copy Markdown
Contributor

@bastelfreak bastelfreak commented May 7, 2026

previously, we called the default rake task, which runs the unit tests and afterwards rubocop. That doesn't make much sense. We usually run rubocop once, before generating the matrix. We can do the same here.

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document and added a Signed-off-by annotation to each of my commits
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

previously, we called the default rake task, which runs the unit tests
and afterwards rubocop. That doesn't make much sense. We usually run
rubocop once, before generating the matrix. We can do the same here.

Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak bastelfreak merged commit fe60587 into OpenVoxProject:main May 8, 2026
7 checks passed
@bastelfreak bastelfreak deleted the rubocop2 branch May 8, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants