Pass full options hashes from component.add_source#89
Merged
Sharpie merged 1 commit intoMay 9, 2026
Merged
Conversation
Sharpie
force-pushed
the
pass-options-for-secondary-sources
branch
from
771a526 to
c018457
Compare
Prior to this commit, the `add_source` method of the would accept any number of keyword arguments, but silently ignored any that were not `ref` or `sum`. The Git and Http sources accept many options, critically `sum_type` which allows checksums other than MD5 to be used. This commit updates the logic in `lib/vanagon/component.rb` to ensure all options are passed to the source constructor. Signed-off-by: Charlie Sharpsteen <charlie@overlookinfratech.com>
Sharpie
force-pushed
the
pass-options-for-secondary-sources
branch
from
c018457 to
07d1ce5
Compare
7 tasks
bastelfreak
approved these changes
May 9, 2026
nmburgan
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
add_sourcemethod of the would accept any number of keyword arguments, but silently ignored any that were notreforsum. The Git and Http sources accept many options, criticallysum_typewhich allows checksums other than MD5 to be used.This commit updates the logic in
lib/vanagon/component.rbto ensure all options are passed to the source constructor.Short description
Checklist
I have:
Signed-off-byannotation to each of my commits