Merged
Conversation
Contributor
lmajano
commented
Jul 3, 2025
lmajano
commented
- Updated CommandBox to v6.2.1
- EditorConfig support for VSCode and IntelliJ
- Added gitattributes file to ignore unnecessary files in git
- Added markdownlint configuration and markdown lint fix
- Dependabot for automatic dependency updates and security fixes
- Added gitattributes file to ignore unnecessary files in git - Added markdownlint configuration and markdown lint fix
Bumps [docker/login-action](https://github.com/docker/login-action) from 1 to 3. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v1...v3) --- updated-dependencies: - dependency-name: docker/login-action dependency-version: '3' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/dot-github/workflows/docker/build-push-action-6 Bump docker/build-push-action from 2 to 6 in /.github/workflows
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v2...v3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: '3' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR bumps CommandBox to v6.2.1 across workflows, adds editor and lint support files, and updates documentation and CI/dependency automation.
- Upgraded CommandBox version and image tags in CI workflows
- Introduced EditorConfig, .gitattributes, markdownlint, and Dependabot config
- Overhauled README and changelog for the new release
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/index.cfm | Added environment-based debug toggle |
| changelog.md | Inserted new 6.2.1/3.13.5 release entry |
| README.md | Updated docs, tables, examples, and version badges |
| LICENSE | Added Apache 2.0 license file |
| .markdownlint.json | Added markdownlint configuration |
| .github/workflows/scans.yml | Bumped action versions and CommandBox version |
| .github/workflows/release.yml | Updated checkout action and bump variables |
| .github/workflows/pull-request.yml | Updated checkout action and CommandBox version |
| .github/dependabot.yml | Added Dependabot configuration for GH Actions & Docker |
| .gitattributes | Added file attributes for diff and merging |
| .editorconfig | Added base EditorConfig settings |
Comments suppressed due to low confidence (3)
README.md:805
- [nitpick] Remove the personal religious section from the README to keep the project documentation focused and professional.
## HONOR GOES TO GOD ABOVE ALL
.github/workflows/scans.yml:14
- Pin this action to a stable version tag (e.g.,
v2) rather thanmasterto avoid unexpected breaks.
runs-on: ubuntu-latest
.github/dependabot.yml:9
- Dependabot's
directoryshould be specified relative to the repo root without a leading slash (.github/workflows) to ensure updates are detected.
directory: "/.github/workflows" # Location of .github/workflows
| <cfscript> | ||
| system = createObject( "java", "java.lang.System" ); | ||
| env = system.getenv(); | ||
| debugEnabled = structKeyExists( env, "ENVIRONMENT" ) ? ( env.ENVIRONMENT == "development" ) : false; |
There was a problem hiding this comment.
Declare debugEnabled with var inside the <cfscript> to avoid polluting the page scope, e.g., var debugEnabled = ....
Suggested change
| debugEnabled = structKeyExists( env, "ENVIRONMENT" ) ? ( env.ENVIRONMENT == "development" ) : false; | |
| var debugEnabled = structKeyExists( env, "ENVIRONMENT" ) ? ( env.ENVIRONMENT == "development" ) : false; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.