pcre2test: detect setrlimit instead of hardcoding platform list#893
Open
puffnfresh wants to merge 1 commit intoPCRE2Project:mainfrom
Open
pcre2test: detect setrlimit instead of hardcoding platform list#893puffnfresh wants to merge 1 commit intoPCRE2Project:mainfrom
puffnfresh wants to merge 1 commit intoPCRE2Project:mainfrom
Conversation
Replace the growing platform preprocessor check for -S flag support with AC_CHECK_FUNCS/check_symbol_exists detection of setrlimit. This automatically handles any platform lacking setrlimit (WASI, VMS, etc.) without maintaining a manual list. Haiku and z/OS are kept as explicit exclusions because they provide setrlimit but don't support RLIMIT_STACK.
Member
|
Thank you, there are several of these in pcre2test and pcre2grep which I would love to clear up. Much appreciated! I will have to do a little bit of platform checking testing before I merge, but in principle, this is good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the growing platform preprocessor check for -S flag support with AC_CHECK_FUNCS/check_symbol_exists detection of setrlimit. This automatically handles any platform lacking setrlimit (WASI, VMS, etc.) without maintaining a manual list.
Haiku and z/OS are kept as explicit exclusions because they provide setrlimit but don't support RLIMIT_STACK.