Draft: Adds strong typing, more typing, php 8.2 features#280
Draft
specialtactics wants to merge 8 commits intomainfrom
Draft
Draft: Adds strong typing, more typing, php 8.2 features#280specialtactics wants to merge 8 commits intomainfrom
specialtactics wants to merge 8 commits intomainfrom
Conversation
Contributor
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This is an early draft at this stage.
The aim is to address some recent challenges with the typing of some config ints in a backwards-compatible way, while also adding typing in various places where reasonable.
Discussion Points
Changes Beyond types
Renamed the function "customClaims" to "getCustomClaims" to be in line with "setCustomClaims". I kept the current one, just marked as deprecated.