Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds logging of the module version in the build action to surface which version is being packed.
- Logs the
ModuleVersionenvironment variable before running the pack task. - Updates the
runstep in.github/actions/build/action.ymlto include verbose output.
Comments suppressed due to low confidence (3)
.github/actions/build/action.yml:49
- [nitpick] Consider using a YAML multiline script block (
|) for therunstep to improve readability and reduce the complexity of a single long inline command.
run: $ModuleVersion=$Env:ModuleVersion;Write-Verbose "Using version: $ModuleVersion" -Verbose;./build.ps1 -tasks pack
.github/actions/build/action.yml:49
Write-Verboseoutput may be suppressed unless-Verboseis enabled; usingWrite-Hostor explicitly setting$VerbosePreference = 'Continue'can ensure the version is always visible in the GitHub Actions log.
run: $ModuleVersion=$Env:ModuleVersion;Write-Verbose "Using version: $ModuleVersion" -Verbose;./build.ps1 -tasks pack
.github/actions/build/action.yml:49
- [nitpick] The temporary assignment to
$ModuleVersionisn’t strictly needed; you can reference$Env:ModuleVersiondirectly in the logging command to simplify the script.
run: $ModuleVersion=$Env:ModuleVersion;Write-Verbose "Using version: $ModuleVersion" -Verbose;./build.ps1 -tasks pack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.