Skip to content

Fix broken link in the README #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
radazzouz merged 2 commits into from
May 28, 2019
Merged

Fix broken link in the README #232

radazzouz merged 2 commits into from
May 28, 2019

Conversation

@radazzouz
Copy link
Contributor

@radazzouz radazzouz commented May 27, 2019 •
edited
Loading

Fixes #231

Details

This PR fixes a broken link in the README.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@radazzouz radazzouz self-assigned this May 27, 2019
@radazzouz radazzouz force-pushed the rad/fix-broken-link branch from f075016 to 1ab7268 Compare May 27, 2019 22:35
@radazzouz radazzouz force-pushed the rad/fix-broken-link branch from 1ab7268 to 561c2d3 Compare May 28, 2019 12:23
@radazzouz radazzouz merged commit c31d3c6 into master May 28, 2019
@radazzouz radazzouz deleted the rad/fix-broken-link branch May 28, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@radazzouz radazzouz

Labels

enhancement iOS READY TO REVIEW

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Looking for proptypes

2 participants

@radazzouz