Skip to content

Update to PSPDFKit for Android 6.1.1 #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
irgendeinich merged 2 commits into from
Jan 21, 2020
Merged

Update to PSPDFKit for Android 6.1.1 #342

irgendeinich merged 2 commits into from
Jan 21, 2020

Conversation

@irgendeinich
Copy link
Contributor

@irgendeinich irgendeinich commented Jan 17, 2020 •
edited
Loading

Details

  • Bumps the used PSPDFKit version to 6.1.1. Resolves #341
  • Also removes warnings related to deprecated build options.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@irgendeinich irgendeinich self-assigned this Jan 17, 2020
tomassurin
tomassurin approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@tomassurin tomassurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irgendeinich irgendeinich merged commit c1d9a8f into master Jan 21, 2020
@irgendeinich irgendeinich deleted the reinhard/update-pspdfkit-6.1.1 branch January 21, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomassurin tomassurin tomassurin approved these changes

Assignees

@irgendeinich irgendeinich

Labels

Android READY TO REVIEW

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Android] Update PSPDFKit for Android version to 6.1.1

3 participants

@irgendeinich @tomassurin