Conversation
…ct Native project
steviki
approved these changes
Apr 8, 2020
Contributor
steviki
left a comment
steviki
left a comment
There was a problem hiding this comment.
I tested this and everything works fine. Looks good to me!
And sorry for the late review!
Co-Authored-By: Stefan Kieleithner <stefan.kieleithner@gmail.com>
irgendeinich
approved these changes
Apr 15, 2020
Contributor
irgendeinich
left a comment
irgendeinich
left a comment
There was a problem hiding this comment.
LGTM! Doesn't affect Android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
In this PR, we're bridging the Instant example from native PSPDFKit Catalog to the NativeCatalog React Native sample project.
Acceptance Criteria
package.json,package-lock.json,samples/Catalog/package.json, andsamples/NativeCatalog/package.json(see example commit: 1bf805f).