Skip to content

Update PSPDFKit Version to 6.3.0 #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
irgendeinich merged 2 commits into from
Apr 24, 2020
Merged

Update PSPDFKit Version to 6.3.0 #364

irgendeinich merged 2 commits into from
Apr 24, 2020

Conversation

@irgendeinich
Copy link
Contributor

@irgendeinich irgendeinich commented Apr 16, 2020 •
edited
Loading

Details

Resolves #359

  • Fixed by replacing performApplyConfiguration with a new implementation.

Resolves #352

  • Fixed by updating to PSPDFKit for Android 6.3.0

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

Update PSPDFKit Version to 6.3.0
1443826 
Remove deprecated performApplyConfiguration method and replace with alternative solution
@irgendeinich irgendeinich self-assigned this Apr 16, 2020
@irgendeinich irgendeinich merged commit cbfde7d into master Apr 24, 2020
@irgendeinich irgendeinich deleted the reinhard/android-6.3 branch April 24, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@davidschreiber davidschreiber davidschreiber approved these changes

@simoarpe simoarpe simoarpe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@irgendeinich irgendeinich

Labels

Android READY TO REVIEW

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Android] menuItemGrouping lost when switching between Default/Night [Android Only] Have problem with fragmentTag.

4 participants

@irgendeinich @davidschreiber @simoarpe