Skip to content

Fix annotation tapped events not being emitted when editing is disabled #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
radazzouz merged 1 commit into from
Jan 11, 2021
Merged

Fix annotation tapped events not being emitted when editing is disabled #385

radazzouz merged 1 commit into from
Jan 11, 2021

Conversation

@irgendeinich
Copy link
Contributor

@irgendeinich irgendeinich commented Jan 5, 2021 •
edited by radazzouz
Loading

Details

This changes how onAnnotationTapped events are emitted. Instead of relying on the onPrepareAnnotationSelection we now use the onPageClick which also works when annotation editing is disabled.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@irgendeinich irgendeinich self-assigned this Jan 5, 2021
radazzouz
radazzouz approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@radazzouz radazzouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Does not impact iOS.

simoarpe
simoarpe approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@simoarpe simoarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@radazzouz
Copy link
Contributor

radazzouz commented Jan 11, 2021

As agreed with @irgendeinich in Slack, I am merging this PR to publish a new release.

@radazzouz radazzouz merged commit 0355c8e into master Jan 11, 2021
@irgendeinich irgendeinich deleted the reinhard/fix-annotation-tap branch January 12, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@simoarpe simoarpe simoarpe approved these changes

@radazzouz radazzouz radazzouz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@irgendeinich irgendeinich

Labels

Android READY TO REVIEW

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@irgendeinich @radazzouz @simoarpe