Allow for Zarr stores being passed to ParticleFile#1303
Merged
erikvansebille merged 16 commits intoParcels-code:masterfrom Feb 7, 2023
willirath:towards-arbitrary-zarr-stores
Merged
Allow for Zarr stores being passed to ParticleFile#1303erikvansebille merged 16 commits intoParcels-code:masterfrom willirath:towards-arbitrary-zarr-stores
erikvansebille merged 16 commits intoParcels-code:masterfrom
willirath:towards-arbitrary-zarr-stores
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's allow for directly passing a
zarr.storage.Storeobject toParticleFile. This will allow for a couple of advanced output strategies:MemoryStoreRedisStorecapturing output in a zip file using a(Possible but inefficient and throwing lots of warnings.)ZipZtoreTodos:
ParticleFileworks for Zarr stores directly.