Skip to content

Comments

docs: update README and minor MavenCentral pom file attribute#68

Merged
wzieba merged 2 commits intomasterfrom
update_documentation
Sep 13, 2023
Merged

docs: update README and minor MavenCentral pom file attribute#68
wzieba merged 2 commits intomasterfrom
update_documentation

Conversation

@wzieba
Copy link
Collaborator

@wzieba wzieba commented Sep 12, 2023 •
edited
Loading

Description

This small PR updates documentation link for the Android SDK and removes developers attribute in favor of organiation (less prone to changes).

@wzieba wzieba marked this pull request as ready for review September 12, 2023 11:12
@wzieba wzieba requested a review from ParaskP7 September 12, 2023 11:12
@ParaskP7 ParaskP7 self-assigned this Sep 13, 2023
ParaskP7
ParaskP7 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for both updates @wzieba ! 💯

EXTRAS:

  1. Suggestion (💡): This is highly debatable and I can understand why you chose docs for this ba52e8b commit, but I think it might have been better if you had chosen build instead, as this is related to a build related change with publishing... 🤷

@wzieba wzieba merged commit 57477d8 into master Sep 13, 2023
@wzieba wzieba deleted the update_documentation branch September 13, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ParaskP7 ParaskP7 ParaskP7 approved these changes

Assignees

@ParaskP7 ParaskP7

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wzieba @ParaskP7