Support recoverability for Azure ServiceBus dead letter messages#5434
Merged
andreasohlund merged 11 commits intomasterfrom May 6, 2026
Merged
Support recoverability for Azure ServiceBus dead letter messages#5434andreasohlund merged 11 commits intomasterfrom
andreasohlund merged 11 commits intomasterfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
DavidBoike
changed the title
andreasohlund
force-pushed
the
handle-asb-dlq
branch
from
abfb238 to
cd5636b
Compare
andreasohlund
changed the title
Member
|
Looks like there's a problem in the ASB container with DetermineQueuesToCreate coming up with a duplicate for |
Member
Author
|
I'm investigating |
andreasohlund
commented
May 6, 2026
andreasohlund
force-pushed
the
handle-asb-dlq
branch
from
26646d9 to
b2e7f69
Compare
Member
Author
|
Problems found and fixed |
| public class EndpointDetailsParserTests | ||
| { | ||
| [Test] | ||
| public void Receiving_endpoint_should_use_failed_queue_machine_when_host_is_missing() |
Contributor
There was a problem hiding this comment.
It is not clear to me what host is missing means in this case especially because the other test also doesn't seem to have a host.
All I see is a machine name being there or not after the at sign
danielmarbach
approved these changes
May 6, 2026
Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, messages dead-lettered in AzureServiceBus can be auto-forwarded to the error queue and managed in ServicePulse