Merged
Conversation
Contributor
Author
|
@PhilBastian I haven't had a chance to fully test this yet but this is what you had in mind right? |
PhilBastian
approved these changes
Sep 18, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the FAIcon component to consolidate tooltip handling by replacing individual v-tippy directives on menu item icons with a centralized approach. The FAIcon component now uses v-tippy internally, while all menu items pass tooltip text via the title prop instead of using v-tippy directly.
- Centralized tooltip handling in the FAIcon component
- Replaced
v-tippywithtitleprop across all menu item components
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Frontend/src/components/FAIcon.vue | Updated to use v-tippy directive internally instead of title attribute |
| src/Frontend/src/views/throughputreport/ThroughputMenuItem.vue | Changed from v-tippy to title prop for icon tooltip |
| src/Frontend/src/components/monitoring/MonitoringMenuItem.vue | Changed from v-tippy to title prop for icon tooltip |
| src/Frontend/src/components/heartbeats/HeartbeatsMenuItem.vue | Changed from v-tippy to title prop for icon tooltip |
| src/Frontend/src/components/failedmessages/FailedMessagesMenuItem.vue | Changed from v-tippy to title prop for icon tooltip |
| src/Frontend/src/components/events/EventsMenuItem.vue | Changed from v-tippy to title prop for icon tooltip |
| src/Frontend/src/components/dashboard/DashboardMenuItem.vue | Changed from v-tippy to title prop for icon tooltip |
| src/Frontend/src/components/customchecks/CustomChecksMenuItem.vue | Changed from v-tippy to title prop for icon tooltip |
| src/Frontend/src/components/configuration/ConfigurationMenuItem.vue | Changed from v-tippy to title prop for icon tooltip |
| src/Frontend/src/components/audit/AuditMenuItem.vue | Changed from v-tippy to title prop for icon tooltip |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
danielmarbach
force-pushed
the
faicon
branch
from
552ed62 to
76472cd
Compare
danielmarbach
force-pushed
the
faicon
branch
from
76472cd to
948924d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow through on #2615