Skip to content

Fix SMB users lookup and return last password set date#214

Merged
NeffIsBack merged 7 commits into
mainfrom
issue/203
Mar 21, 2024
Merged

Fix SMB users lookup and return last password set date#214
NeffIsBack merged 7 commits into
mainfrom
issue/203

Conversation

@Marshall-Hallenbeck

@Marshall-Hallenbeck Marshall-Hallenbeck commented Mar 20, 2024

Copy link
Copy Markdown
Collaborator
  • allow requesting only specific users when calling --users (fixes users user returns all users instead of specified user #203)
  • return LastPwSet in human-readable format for --users
  • remove unnecessary print statement before printing users
  • add in header line for user table
  • add more debug statements in samruser.py
  • print bad password attempt #
  • functionize code for future use, allowing other areas of code to call into these user lookup functions

Example of getting all users:
image

Example of getting specific users:
image

@Marshall-Hallenbeck Marshall-Hallenbeck added the bug-fix This Pull Request fixes a bug label Mar 20, 2024
@Marshall-Hallenbeck Marshall-Hallenbeck self-assigned this Mar 20, 2024
…PwSet, and functionize more code for future use
@Marshall-Hallenbeck

Copy link
Copy Markdown
Collaborator Author

It was brought up in #219 that the bad pw count is missing from this feature, so I've re-added it:
image

NeffIsBack
NeffIsBack previously approved these changes Mar 21, 2024

@NeffIsBack NeffIsBack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
image

@NeffIsBack NeffIsBack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better :D

image

@NeffIsBack NeffIsBack merged commit 0608628 into main Mar 21, 2024
@NeffIsBack NeffIsBack deleted the issue/203 branch March 21, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix This Pull Request fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

users user returns all users instead of specified user

2 participants