Skip to content

Neff qol the second#242

Merged
NeffIsBack merged 2 commits into
mainfrom
neff-qol
Apr 1, 2024
Merged

Neff qol the second#242
NeffIsBack merged 2 commits into
mainfrom
neff-qol

Conversation

@NeffIsBack

Copy link
Copy Markdown
Member

Another small QOL PR with some neat stuff:

  1. We can catch the ERROR_DEPENDENT_SERVICES_RUNNING as this is known and can happen in windows environments, there is no need for a large traceback every time
  2. I increased the max_worker from threadpool to 265. This will allow to scan an entire subnet with one execution, so that you don't have to wait 3x for connection time outs as you would scan only 100 hosts at a time until now. This safes a lot of time when scanning larger ranges

Before and after for the error:
image
image
image

Time comparison between main branch and this one for an entire subnet:
image

@NeffIsBack NeffIsBack added the enhancement New feature or request label Apr 1, 2024
Comment thread nxc/connection.py
@NeffIsBack NeffIsBack merged commit 75e9316 into main Apr 1, 2024
@NeffIsBack NeffIsBack deleted the neff-qol branch April 1, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants