ldap-checker: fix for Python 3.12 compatibility

[exploide]

The ldap-checker module is currently not compatible with Python 3.12+ because ssl.wrap_socket() was deprecated and has been removed. Fixed this by using SSLContext.wrap_socket() instead.

While doing so, my code linter was complaining so I added a cleanup and code quality commit first. The commits are separate to make reviewing a cleanup commit and a compatibility fix commit easier.

[NeffIsBack]

Thanks for the fix! I'll check it out soon. I would let the elif statements though, there is no reason to check the error multiple times if one matches.

[exploide]

I would let the elif statements though, there is no reason to check the error multiple times if one matches.

The thing is, there is always a return right before the next if, so it will stop anyway if it evaluates to True once. That's why the linter was complaining.

However, if any stylistic change is not at yours discretion, please let me know. I can change that of course. :)

[NeffIsBack]

I would let the elif statements though, there is no reason to check the error multiple times if one matches.

The thing is, there is always a return right before the next if, so it will stop anyway if it evaluates to True once. That's why the linter was complaining.

However, if any stylistic change is not at yours discretion, please let me know. I can change that of course. :)

Makes sense, i would leave it anyway though, because it is clearer, that we can enter only one if statement.
Btw which linter do you use?

[exploide]

Okay, just stripped the cleanup commit.

I'm currently using pylint. I know you are using ruff, and I use it on a project at work, too. But haven't switched to it entirely, yet.

[NeffIsBack]

Could reproduce on py3.12.3:

Patch LGTM for 3.12 and also 3.11:

[NeffIsBack]

@exploide thanks for the report and fix!