Upgrade dploot to 3.0.3#491
Merged
Merged
Conversation
Member
|
Nice one!! |
Collaborator
mpgn
approved these changes
Dec 16, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Upgrade of dploot to version 3.0.3 (major update) so I had to update the code over DPAPI stuff:
wamto dump Entra and M365 access token from Token Broker CacheType of change
Please delete options that are not relevant.
How Has This Been Tested?
ruff --preview, e2e_tests.py have been running
To test the WAM module, just connect a Microsoft account on a Teams or Outlook, and make sure to connect to it with an administrator account (it's DPAPI stuff so domain admin will make it easier to test because you will use domain backup key)
You can try all other DPAPI stuff to tests the changes, but it SHOULD be good.
Screenshots (if appropriate):
Cannot provide screenshots for the WAM module, because it output my mail and a Teams access token for my account.
Checklist:
poetry run python -m ruff check . --preview, use--fixto automatically fix what it can)