fix trust relation for smb#510
Merged
Merged
Conversation
mpgn
requested review from
Marshall-Hallenbeck,
NeffIsBack and
zblurx
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fix the trust relation between two AD (it was broken)
The fix is very simple,
self.remoteNameneed to be equal to{self.hostname}.{self.targetDomain}and not{self.hostname}.{self.domain}as your domain is not the same as your target domain (since it's a trust)Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested against GOAD lab
Checklist:
poetry run python -m ruff check . --preview, use--fixto automatically fix what it can)