Conversation
Member
|
Highly appreaciated! This is also ancient stuff. Can you also rip out |
Collaborator
Author
done ✅ |
NeffIsBack
reviewed
May 6, 2025
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the
NXCSMBServerclass and its associated functionality from the codebase, simplifying the SMB-related code. The changes include the removal of the server implementation, decorator, and imports referencing this functionality.Removal of
NXCSMBServerfunctionality:nxc/servers/smb.py: Fully removed theNXCSMBServerclass, which implemented a custom SMB server, along with its imports and threading logic.nxc/protocols/smb.py: Deleted therequires_smb_serverdecorator, which previously managed the lifecycle of theNXCSMBServerinstance, and removed related imports. [1] [2]Cleanup of references to removed functionality:
netexec.spec: Removed the reference tonxc.servers.smbfrom the analysis configuration, reflecting the removal of theNXCSMBServerimplementation.Type of change
Please delete options that are not relevant.