Skip to content

remove old server code unused#662

Merged
mpgn merged 12 commits into
mainfrom
cleanup
May 7, 2025
Merged

remove old server code unused#662
mpgn merged 12 commits into
mainfrom
cleanup

Conversation

@mpgn

@mpgn mpgn commented Apr 26, 2025

Copy link
Copy Markdown
Collaborator

Description

This pull request removes the NXCSMBServer class and its associated functionality from the codebase, simplifying the SMB-related code. The changes include the removal of the server implementation, decorator, and imports referencing this functionality.

Removal of NXCSMBServer functionality:

  • nxc/servers/smb.py: Fully removed the NXCSMBServer class, which implemented a custom SMB server, along with its imports and threading logic.

  • nxc/protocols/smb.py: Deleted the requires_smb_server decorator, which previously managed the lifecycle of the NXCSMBServer instance, and removed related imports. [1] [2]

Cleanup of references to removed functionality:

  • netexec.spec: Removed the reference to nxc.servers.smb from the analysis configuration, reflecting the removal of the NXCSMBServer implementation.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@NeffIsBack

Copy link
Copy Markdown
Member

Highly appreaciated! This is also ancient stuff. Can you also rip out on_response/on_request in the example module and the smb.py module logic?

@mpgn

mpgn commented Apr 27, 2025

Copy link
Copy Markdown
Collaborator Author

Highly appreaciated! This is also ancient stuff. Can you also rip out on_response/on_request in the example module and the smb.py module logic?

done ✅

Comment thread nxc/connection.py

@NeffIsBack NeffIsBack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpgn mpgn merged commit 413e5eb into main May 7, 2025
@mpgn mpgn deleted the cleanup branch May 7, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants