Open
Conversation
DBIx-Class incorrectly warns about missing primary key values when using scalar references for database functions. This test reproduces the issue where scalar references like \'ABS(RANDOM())' trigger 'Missing value for primary key' warnings even though they represent valid database function calls. The test demonstrates: - Scalar references should NOT trigger missing PK warnings (currently fails) - Truly missing PKs should still warn correctly (works) - Explicit values should not warn (works)
DBIx-Class incorrectly warned about missing primary key values when using scalar references for database functions like \'UUID()'. The warning logic only tracked auto-increment columns but was triggered for non-auto-increment primary keys that weren't properly detected as supplied. Add tracking for any supplied primary key column using the same logic that determines literal values, ensuring scalar references are recognized as supplied values and don't trigger spurious warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attempt to do something useful for the project.