Prevent duplicate camera activation#2352
Open
halfaleague wants to merge 2 commits intoPhotonVision:mainfrom
Open
Prevent duplicate camera activation#2352halfaleague wants to merge 2 commits intoPhotonVision:mainfrom
halfaleague wants to merge 2 commits intoPhotonVision:mainfrom
Conversation
github-actions
bot
added
the
backend
Member
|
I think this might be symptomatic of a deeper issue. I'll try and take a deeper look at some point tonight. |
github-actions
bot
added
the
frontend
Contributor
|
I think this check might be good to have in place! But I was under the impression our current design didn't allow this happen in the first place. Can you help me understand how Photon as currently written can let you get into this bad state? |
Member
|
Could you tell me more about what device you're using and send logs as well? I've been unable to reproduce this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is mainly an FYI. There seems to be a problem distinguishing cameras when all 3 cameras are exactly the same.
Prevent reactivating a disabled camera config when its unique-path is already in use by an active VisionModule. This avoids two modules binding the same device and showing duplicate streams on the camera matching page.
Correct the name that is shown in the UI.
Camera cards now show the nickname as the title with the device model as a subtitle to make identical cameras distinguishable.
Testing
Run in the UI with 3 identical cameras.
The 3 cameras show 2 different images only. The second and the third camera are the same.
When you try to delete the second or third cameras, they confuse the title and the camera to name to type to delete.
Working! Three unique images are displayed.
