Skip to content

fix(majc): v1.1.6 #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
collectedmind merged 2 commits into from
Aug 26, 2025
Merged

fix(majc): v1.1.6 #1448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6583222
chore(cleanup): remove opt-in-monster
collectedmind Aug 26, 2025
80a5f6e
fix(majc): update to 0.1.16
collectedmind Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"@emotion/css": "11.13.5",
"@emotion/react": "11.14.0",
"@freestar/pubfig-adslot-react-component": "3.6.2",
"@mozilla-services/majc": "https://github.com/mozilla-services/majc#v0.1.5",
"@mozilla-services/majc": "https://github.com/mozilla-services/majc#v0.1.6",
"@n8tb1t/use-scroll-position": "2.0.3",
"@popperjs/core": "2.11.8",
"@sentry/integrations": "7.114.0",
Expand Down
16 changes: 0 additions & 16 deletions clients/web/src/common/utilities/third-party/opt-in-monster.js
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions clients/web/src/connectors/third-party/third-party-init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { useDispatch } from 'react-redux'
import Script from 'next/script'

import { pageview } from 'common/utilities/analytics/ga'
import { loadOptinMonster } from 'common/utilities/third-party/opt-in-monster'
import { ONETRUST_EMPTY_DEFAULT } from 'common/constants'
import { trackPageView } from 'connectors/snowplow/snowplow.state'
import { initializeSnowplow } from 'common/setup/snowplow'
Expand Down Expand Up @@ -154,12 +153,6 @@ export function ThirdPartyInit() {
analyticsInitSet(true)
}, [oneTrustReady, analyticsCookie, analyticsInit, dispatch, user_status, sess_guid, user_id])

// Load Opt In Monster for marketing/conversion adventurers ... but not during dev
useEffect(() => {
if (!isProduction) return () => {}
loadOptinMonster()
}, [isProduction])

// Track Snowplow Page Views
useEffect(() => {
if (user_status === 'pending') return () => {}
Expand Down
18 changes: 9 additions & 9 deletions clients/web/src/pages/_app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,12 +175,14 @@ function PocketWebClient({ Component, pageProps, err }) {

return (
<ViewportProvider>
<ThirdPartyInit />
<DevTools />
<Shortcuts />
<CacheProvider value={cache}>
{shouldRender ? <Component {...pageProps} err={err} /> : null}
</CacheProvider>
<MozAdsConfigProvider config={{ gppEnabled: true }}>
<ThirdPartyInit />
<DevTools />
<Shortcuts />
<CacheProvider value={cache}>
{shouldRender ? <Component {...pageProps} err={err} /> : null}
</CacheProvider>
</MozAdsConfigProvider>
</ViewportProvider>
)
}
Expand All @@ -189,9 +191,7 @@ function AppWithStore({ Component, ...rest }) {
const { store, props } = wrapper.useWrappedStore(rest)
return (
<Provider store={store}>
<MozAdsConfigProvider config={{ gppEnabled: true }}>
<PocketWebClient Component={Component} {...props} />
</MozAdsConfigProvider>
<PocketWebClient Component={Component} {...props} />
<ConfirmItemsImport />
</Provider>
)
Expand Down
68 changes: 9 additions & 59 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading