Skip to content

allow CallableModelGenericType to be fully fledged callable model base#137

Merged
timkpaine merged 2 commits intomainfrom
tkp/sc2
Oct 28, 2025
Merged

allow CallableModelGenericType to be fully fledged callable model base#137
timkpaine merged 2 commits intomainfrom
tkp/sc2

Conversation

@timkpaine
Copy link
Member

@timkpaine timkpaine commented Oct 28, 2025

No description provided.

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@timkpaine timkpaine added the type: enhancement Minor improvements label Oct 28, 2025
@github-actions
Copy link
Contributor

Test Results

428 tests  +2   424 ✅ +2   23s ⏱️ ±0s
  1 suites ±0     4 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit df23202. ± Comparison against base commit 5d07635.

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 88.37209% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.37%. Comparing base (5d07635) to head (df23202).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
ccflow/callable.py 80.00% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   95.41%   95.37%   -0.04%     
==========================================
  Files         120      120              
  Lines        6755     6794      +39     
  Branches      427      432       +5     
==========================================
+ Hits         6445     6480      +35     
- Misses        202      203       +1     
- Partials      108      111       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ptomecek
ptomecek previously approved these changes Oct 28, 2025
@timkpaine timkpaine dismissed ptomecek’s stale review October 28, 2025 21:53

The merge-base changed after approval.

@timkpaine timkpaine merged commit aa3143c into main Oct 28, 2025
4 of 6 checks passed
@timkpaine timkpaine deleted the tkp/sc2 branch October 28, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Minor improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants