-
Notifications
You must be signed in to change notification settings - Fork 2
feat: arr CLI
#372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
feat: arr CLI
#372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const changes: FileChange[] = []; | ||
|
|
||
| for (const line of lines) { | ||
| const match = line.match(/^([MADR])\s+(.+)$/); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
This regular expression that depends on library input may run slow on strings starting with 'A ' and with many repetitions of ' '.
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stale
a57cf4f to
d6e730e
Compare
Contributor
Author
Merge from bottom to top, or use |
3965c7d to
e3c545a
Compare
e3c545a to
a42be58
Compare
5c28359 to
e351407
Compare
a25e69e to
7be0bf9
Compare
Contributor
Author
|
Closing in favor of a stacked PR with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI for stacked PR management using JJ. Generally makes JJ easier to grasp.
Consists of a
corepackage and acliapp. The CLI is fairly thin, and all functionality occurs incore, so we can directly use that via the Array desktop app as well.