Allow specifying the flag in the example script #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haacked
force-pushed
the
haacked/allow-passing-flag
branch
from
4835bf0 to
91268d0
Compare
dmarticus
approved these changes
Feb 6, 2025
Contributor
dmarticus
left a comment
dmarticus
left a comment
There was a problem hiding this comment.
I don't feel strongly either way about this; I typically just go in and configure the example script to do what I want it to, but this seems useful enough.
| print( | ||
| posthog.feature_enabled( | ||
| "person-on-events-enabled", | ||
| args.flag, # Use the flag from command line arguments |
Contributor
There was a problem hiding this comment.
fwiw, this only changes the first test flag in this case, the subsequent flags will still use the hard coded values. Seems fine if you're only really using the example script for the first case.
Collaborator
Author
There was a problem hiding this comment.
I’ll cross those bridges if the need arises. 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a little quality of life improvement. When using the example script, it creates an event for the feature flag
person-on-events-enabled. This change adds an optional argument that lets you change the feature-flag key for the event like so:If the flag is omitted, the script behaves the same as it always did.