Closed
Conversation
Signed-off-by: Jaap Schouten <jaap.schouten@alliander.com>
Signed-off-by: Jaap Schouten <jaap.schouten@alliander.com>
Signed-off-by: Jaap Schouten <jaap.schouten@alliander.com>
This was referenced Apr 7, 2026
Comment on lines
+504
to
+505
| @overload | ||
| def deserialize(cls: type[Self], path: dict, mode: Literal["dict"]) -> Self: ... |
Member
There was a problem hiding this comment.
Haven't looked at the full code yet, but I think having path as the object you need to provide the dict is a bit odd.
My personal preference would be either:
- Add a
dataargument that we use if filled (and error if both path and data is filled) - Add a separate method like:
deserialize_object. Which is used to deserialize from a python object. So we have two methods; one file based, one object based. Both of them can later be extended with additional modes if needed.
This somewhat follows thejsonsetup for example. Which hasjson.loadfrom a file andjson.loadsfrom a string
Signed-off-by: Jaap Schouten <jaap.schouten@alliander.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mode parameter to serialisation with dict as an option