-
Notifications
You must be signed in to change notification settings - Fork 242
Tsmarvin/enable windows arm64 #2267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Tsmarvin/enable windows arm64 #2267
Conversation
- Remove unnecessary extra word in extension comment
…atic. Fixes crash on windows arm64.
Signed-off-by: jasonnorman66994-dot <[email protected]>
|
@jasonnorman66994-dot please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request makes several small improvements to the PowerShell Editor Services codebase, including development environment configuration, API method signature changes, and documentation corrections. The PR title references "enable windows arm64" but the changes appear to be preparatory or supporting changes rather than direct ARM64 enablement.
Changes:
- Added VS Code extension recommendation for Azure development
- Changed
LoadAssemblyInPsesLoadContextfrom static to instance method to allow future extensibility - Fixed grammar in documentation comment for
ToStringSafeextension method
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.vscode/extensions.json |
Adds recommendation for the Azure Account VS Code extension to standardize development environment |
.gitignore |
Adds .vs/ directory to ignore Visual Studio metadata files |
src/PowerShellEditorServices/Utility/Extensions.cs |
Improves clarity of the summary comment for SafeToString extension method by fixing line break placement |
src/PowerShellEditorServices/Extensions/Api/EditorExtensionServiceProvider.cs |
Changes LoadAssemblyInPsesLoadContext from static to instance method with CA1822 suppression for future extensibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /// method will not throw. | ||
| /// </summary> | ||
| /// <param name="obj">The object on which to call ToString()</param> | ||
| /// <returns>The ToString() return value or a suitable error message is that throws.</returns> |
Copilot
AI
Jan 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase "is that throws" should be "if that throws" for grammatical correctness.
| /// <returns>The ToString() return value or a suitable error message is that throws.</returns> | |
| /// <returns>The ToString() return value or a suitable error message if that throws.</returns> |
|
@andyleejordan, @daviwil, and @rjmholt, could you please review this PR? Your insights would be valuable. |
This pull request introduces a recommended VS Code extension for Azure development, updates the method signature for assembly loading to be non-static, and improves documentation clarity in the utility extensions. The most significant changes are grouped below:
Development Environment Improvements:
.vscode/extensions.jsonto recommend thems-vscode.azure-accountextension for VS Code users, helping standardize the development environment.Code Quality and API Changes:
LoadAssemblyInPsesLoadContextinEditorExtensionServiceProvider.csfrom a static to an instance method, suppressing the CA1822 warning to allow for future extensibility.Documentation and Comment Updates:
ToStringSafeextension method inExtensions.csfor improved readability and accuracy.PR Summary
PR Context