[WiP] Add pester test for UnusedConnectionTimeout#663
Open
vthiebaut10 wants to merge 3 commits intoPowerShell:latestw_allfrom
Open
[WiP] Add pester test for UnusedConnectionTimeout#663vthiebaut10 wants to merge 3 commits intoPowerShell:latestw_allfrom
vthiebaut10 wants to merge 3 commits intoPowerShell:latestw_allfrom
Conversation
vthiebaut10
changed the title
PaulHigin
suggested changes
Feb 10, 2023
|
|
||
| # Start SSH process with Remote Forwarding Option to create a connection that doesn't prevent "Unused Connection Timeout" | ||
| $p = Start-Process -FilePath ssh -ArgumentList "-p $port -N -T -R 35000 $localuser1@$server" -PassThru | ||
| Wait-Process $p.Id -Timeout 10 -ErrorAction SilentlyContinue -ErrorVariable timeouted |
There was a problem hiding this comment.
We usually put a wait action in a retry loop, so that the test will finish quicker if the timeout is around the expected 2 minutes (seconds?). The retry loop will retry to up to a maximum time to wait. Also we should try to let the test finish as soon as possible, is the 2 2 minutes or seconds?
Collaborator
Author
There was a problem hiding this comment.
It's 2 seconds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context