Enable redirection guard during service setup#808
Merged
tgauth merged 2 commits intoPowerShell:latestw_allfrom Oct 16, 2025
Merged
Enable redirection guard during service setup#808tgauth merged 2 commits intoPowerShell:latestw_allfrom
tgauth merged 2 commits intoPowerShell:latestw_allfrom
Conversation
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR enables RedirectionGuard mitigation for both sshd.exe and ssh-agent.exe services by creating registry keys during installation. This security enhancement addresses unsafe junction traversal vulnerabilities in Windows as detailed in the Microsoft MSRC blog post from June 2025.
- Registry keys are created under Image File Execution Options for both sshd.exe and ssh-agent.exe with MitigationOptions values
- Both the PowerShell installer script and WiX MSI installer are updated to create these registry entries
- Registry entries are marked as permanent (persisting through uninstall) and only created if they don't already exist
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| contrib/win32/openssh/install-sshd.ps1 | Adds registry key creation logic for RedirectionGuard mitigation for both sshd.exe and ssh-agent.exe |
| contrib/win32/install/shared.wxs | Adds MSI component to create ssh-agent.exe RedirectionGuard registry key |
| contrib/win32/install/server.wxs | Adds MSI component to create sshd.exe RedirectionGuard registry key |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
TravisEz13
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context