Suggested dependency fastshp

[achubaty]

It's been ~8 years since the last update to fastshp, and it's recently failing to compile on R-devel do to stricter use of Rf_* functions instead of their base C/C++ equivalents.

ETA: These failures are causing GitHub Actions failures on R-devel for all of our downstream packages.

We should probably remove this dependency.

[achubaty]

✔ Got fastshp 0.1-2 (source) (3.01 MB)
ℹ Packaging fastshp 0.1-2
✔ Packaged fastshp 0.1-2 (872ms)
ℹ Building fastshp 0.1-2
✖ Failed to build fastshp 0.1-2 (12.3s)
Error: 
! error in pak subprocess
Caused by error in `stop_task_build(state, worker)`:
! Failed to build source package fastshp.
Full installation output:
* installing *source* package 'fastshp' ...
** this is package 'fastshp' version '0.1-2'
staged installation is only possible with locking
** using non-staged installation
** libs
using C compiler: 'gcc.exe (GCC) 13.3.0'
using C++ compiler: 'G__~1.EXE (GCC) 13.3.0'
gcc  -I"C:/R/include" -DNDEBUG     -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -mfpmath=sse -msse2 -mstackrealign   -Wall -pedantic -c atag.c -o atag.o
gcc  -I"C:/R/include" -DNDEBUG     -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -mfpmath=sse -msse2 -mstackrealign   -Wall -pedantic -c boxes.c -o boxes.o
boxes.c: In function 'C_bboxes':
boxes.c:7:24: warning: unused variable 'box' [-Wunused-variable]
    7 |     double *x, *y, *A, box[4];
      |                        ^~~
boxes.c:14:9: warning: 'id' may be used uninitialized [-Wmaybe-uninitialized]
   14 |     lid = id[0];
      |     ~~~~^~~~~~~
boxes.c:6:10: note: 'id' was declared here
    6 |     int *id, ids = 0, i, n, lid, *idv;
      |          ^~
boxes.c:22:20: warning: 'x' may be used uninitialized [-Wmaybe-uninitialized]
   22 |     A[0] = A[2] = x[0];
      |                   ~^~~
boxes.c:7:13: note: 'x' was declared here
    7 |     double *x, *y, *A, box[4];
      |             ^
boxes.c:23:20: warning: 'y' may be used uninitialized [-Wmaybe-uninitialized]
   23 |     A[1] = A[3] = y[0];
      |                   ~^~~
boxes.c:7:17: note: 'y' was declared here
    7 |     double *x, *y, *A, box[4];
      |                 ^
gcc  -I"C:/R/include" -DNDEBUG     -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -mfpmath=sse -msse2 -mstackrealign   -Wall -pedantic -c centr.c -o centr.o
g++ -std=gnu++17  -I"C:/R/include" -DNDEBUG     -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -mfpmath=sse -msse2 -mstackrealign   -Wall -pedantic -DR_NO_REMAP -c clipper.cpp -o clipper.o
clipper.cpp: In constructor 'ClipperLib::OffsetBuilder::OffsetBuilder(const ClipperLib::Polygons&, ClipperLib::Polygons&, bool, double, ClipperLib::JoinType, ClipperLib::EndType, double)':
clipper.cpp:3206:12: warning: unused variable 'deltaSq' [-Wunused-variable]
 3206 |     double deltaSq = delta*delta;
      |            ^~~~~~~
gcc  -I"C:/R/include" -DNDEBUG     -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -mfpmath=sse -msse2 -mstackrealign   -Wall -pedantic -c inside.c -o inside.o
inside.c: In function 'shp_inside':
inside.c:50:10: warning: variable 'p' set but not used [-Wunused-but-set-variable]
   50 |     int *p, up = 0, *r, np, ns, mp = 0, i,
      |          ^
gcc  -I"C:/R/include" -DNDEBUG     -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -mfpmath=sse -msse2 -mstackrealign   -Wall -pedantic -c merge.c -o merge.o
merge.c: In function 'merge_pts':
merge.c:62:5: warning: 'memset' specified bound between 18446744071562067968 and 18446744073709551615 exceeds maximum object size 92233720[36](https://github.com/PredictiveEcology/fireSenseUtils/actions/runs/12837878183/job/35802400818#step:7:37)854775807 [-Wstringop-overflow=]
   62 |     memset(tag, 0, n);
      |     ^~~~~~~~~~~~~~~~~
gcc  -I"C:/R/include" -DNDEBUG     -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -mfpmath=sse -msse2 -mstackrealign   -Wall -pedantic -c pointline.c -o pointline.o
pointline.c: In function 'shp_closest':
pointline.c:88:23: warning: 'md' may be used uninitialized [-Wmaybe-uninitialized]
   88 |             dist[i] = sqrt(md);
      |                       ^~~~~~~~
pointline.c:47:16: note: 'md' was declared here
   47 |         double md;
      |                ^~
g++ -std=gnu++17  -I"C:/R/include" -DNDEBUG     -I"C:/rtools[44](https://github.com/PredictiveEcology/fireSenseUtils/actions/runs/12837878183/job/35802400818#step:7:45)/x86_64-w64-mingw32.static.posix/include"      -O2 -Wall  -mfpmath=sse -msse2 -mstackrealign   -Wall -pedantic -DR_NO_REMAP -c poly.cpp -o poly.o
      |         ^~~~~~~~
poly.cpp:107:24: error: 'getAttrib' was not declared in this scope; did you mean 'Rf_getAttrib'?
  107 |         SET_STRING_ELT(getAttrib(res, R_NamesSymbol), 0, mkChar("parts"));
      |                        ^~~~~~~~~
      |                        Rf_getAttrib
poly.cpp:107:58: error: 'mkChar' was not declared in this scope; did you mean 'char'?
  107 |         SET_STRING_ELT(getAttrib(res, R_NamesSymbol), 0, mkChar("parts"));
      |                                                          ^~~~~~
      |                                                          char
poly.cpp:108:46: error: 'allocVector' was not declared in this scope; did you mean 'Rf_allocVector'?
  108 |         pix = INTEGER(SET_VECTOR_ELT(res, 0, allocVector(INTSXP, ps)));
      |                                              ^~~~~~~~~~~
      |                                              Rf_allocVector
poly.cpp:114:10: error: 'out_pars' was not declared in this scope
  114 |     if (!out_pars)
      |          ^~~~~~~~
poly.cpp:115:[45](https://github.com/PredictiveEcology/fireSenseUtils/actions/runs/12837878183/job/35802400818#step:7:46): error: 'allocVector' was not declared in this scope; did you mean 'Rf_allocVector'?
  115 |         pp = INTEGER(SET_VECTOR_ELT(res, 0, allocVector(INTSXP, totn)));
      |                                             ^~~~~~~~~~~
      |                                             Rf_allocVector
poly.cpp:116:9: error: 'expand' was not declared in this scope; did you mean '_expand'?
  116 |     if (expand && ps > 1)
      |         ^~~~~~
      |         _expand
poly.cpp:118:[46](https://github.com/PredictiveEcology/fireSenseUtils/actions/runs/12837878183/job/35802400818#step:7:47): error: 'allocVector' was not declared in this scope; did you mean 'Rf_allocVector'?
  118 |     double *px = REAL(SET_VECTOR_ELT(res, 1, allocVector(REALSXP, totn + exp_add)));
      |                                              ^~~~~~~~~~~
      |                                              Rf_allocVector
poly.cpp:129:13: error: 'expand' was not declared in this scope; did you mean '_expand'?
  129 |         if (expand && i < ps - 1) {
      |             ^~~~~~
      |             _expand
make: *** [C:/R/etc/x64/Makeconf:296: poly.o] Error 1
ERROR: compilation failed for package 'fastshp'

[eliotmcintire]

Agreed

[achubaty]

resolved in branch