fix(launcher): pass root tsconfig to tsx, fix send help flags, match rlm attributes - #907
Open
Ombhosalee19 wants to merge 1 commit into
Open
Conversation
…rlm attributes Fixes PrimeIntellect-ai#904 Fixes PrimeIntellect-ai#901 Fixes PrimeIntellect-ai#824
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the following issues:
Source launcher tsconfig resolution (#904):
Pass
--tsconfig "$SCRIPT_DIR/tsconfig.json"totsxinprime-agent.shso monorepo workspace package aliases (such as@earendil-works/pi-agent-core) resolve correctly whenprime-agent.shis invoked from outside the repository directory.Send command help flags (#901):
Remove outdated
--steerand--follow-upoptions fromsendcommand help spec inpackages/coding-agent/src/cli/command-registry.ts.Python
rlmAPI handle and subagent attribute matching (#824):Add
session_nameproperty alias toRLMSpawnHandleandnameproperty alias toRLMSubagent. Allowrlm.delete_subagent()to acceptRLMSpawnHandleobjects directly in addition toRLMSubagentandstr.Changes
prime-agent.shpackages/coding-agent/src/cli/command-registry.tsprime-agent-runtime/src/rlm/__init__.pypackages/coding-agent/test/suite/regressions/904-source-launcher-tsconfig.test.tspackages/coding-agent/test/suite/regressions/901-send-help-options.test.tsprime-agent-runtime/test/test_subagent_registry.pypackages/coding-agent/CHANGELOG.mdTesting
npx tsx ../../node_modules/vitest/dist/cli.js --run test/suite/regressions/904-source-launcher-tsconfig.test.ts(passed)npx tsx ../../node_modules/vitest/dist/cli.js --run test/suite/regressions/901-send-help-options.test.ts(passed)PYTHONPATH=src python test/test_subagent_registry.py(passed)npm run check(all formatting, linting, tsgo, installer render, and browser smoke checks passed)Fixes #904
Fixes #901
Fixes #824
Note
Fix source launcher tsconfig, remove stale send flags, and align RLM API attributes
--tsconfig "$SCRIPT_DIR/tsconfig.json"to thetsxinvocation in prime-agent.sh so the launcher works correctly when run outside the repo directory.--steerand--follow-upflags from thesendcommand help spec in command-registry.ts.session_namealias toRLMSpawnHandleandnamealias toRLMSubagentin rlm/init.py so both types expose matching attributes.rlm.delete_subagentto acceptRLMSpawnHandledirectly, deleting byrlm_child_id.Macroscope summarized 2f5cb1a.