Support broadcasting just lora weights and drop support for merged weights#1320
Merged
Jackmin801 merged 44 commits intomainfrom Nov 21, 2025
Merged
Support broadcasting just lora weights and drop support for merged weights#1320Jackmin801 merged 44 commits intomainfrom
Jackmin801 merged 44 commits intomainfrom
Conversation
Comment out the unloading of the LoRA adapter in orchestrator.py. Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>
Member
mikasenghaas
left a comment
There was a problem hiding this comment.
very clean, i love it. nice that we decouple the full vs adapter only weight saving as well, has been bugging me for a while how entangled these were
samsja
reviewed
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds adapter-only filesystem weight broadcasting and runtime LoRA loading, wires LoRA names through orchestrator/scheduler, removes merged-weight path, and updates tests/CI accordingly.
adapter_onlyoption to weight broadcast configs (trainer/rl/config.py); filesystem broadcaster now saves only adapters and writesadapter_config.json; NCCL path disallows adapter-only.get_adapter_state_dictand adapter filename handling intrainer/weights.py; drop merged-LoRA gathering path; simplifygather_weights_on_master.lora_configinto broadcaster setup and persist with adapter saves.OrchestratorConfig.lora_nameand thread throughScheduler; use LoRA name asmodel_nameafter updates.update_weightsnow acceptslora_nameand uses new/v1/load_lora_adapter; avoid base reload when using LoRA.adapter_onlyflag; checkpoint manager unchanged but aligned with new adapter flow.Written by Cursor Bugbot for commit 7857428. This will update automatically on new commits. Configure here.