Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds online MTP training support for Qwen3.5-family models and wires it into the RL/SFT training paths.
Main changes:
ModelConfig.mtpcontrols for auxiliary MTP CE loss, rollout enablement, loss scale, and speculative token count.Qwen3_5ForConditionalGenerationpath, preserving officialmtp.*checkpoint keys.configs/mtp_ablation/qwen35_2b_hendrycks_sanity_non_mtp_non_thinking.toml.Experiment Commands
All commands should be run from the repo root with
uv run. The sanity config assumes a two-GPU local run: GPU 0 for inference and GPU 1 for training.Non-MTP Baseline
Foreground run:
Detached run with logs:
Useful status checks:
MTP Rollout Ablation
Use the same baseline config, enabling MTP from the CLI so the only intentional experiment difference is MTP training plus speculative rollout:
This resolves vLLM speculative decoding to:
Recommended sequence:
Validation
Dry-runs completed:
Focused GPU unit tests still need to be run before merge: