Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
step,group_id,example_id, optionalinstance_id, andenv_nameso downstream rollout logs can be joined back to scheduler state.Validation
uv run ruff check src/prime_rl/orchestrator/scheduler.py tests/unit/orchestrator/test_scheduler.pyuv run pytest tests/unit/orchestrator/test_scheduler.pyunset PRIME_API_KEY; uv run prime-rl --helpA live
prime-rlscheduling run was not started because even the smallest end-to-end run needs a trainer/inference cluster configuration and GPU allocation. The scheduler emission is covered by the focused unit test; the companion verifiers branch was validated with a one-row live sandbox rollout.Note
Low Risk
Low risk: adds a new informational log line when a rollout group is created plus a unit test; no scheduling logic or data flow is changed beyond emitting extra logs.
Overview
Adds a scheduler log emitted at rollout-group allocation time so downstream rollout logs can be joined back to scheduler state.
Introduces
Scheduler._log_group_created()and calls it when creating a newGroupState, loggingstep,group_id,example_id, optionalinstance_id, andenv_name; includes a focused unit test asserting those fields appear in the emitted message.Reviewed by Cursor Bugbot for commit bd24148. Bugbot is set up for automated code reviews on this repo. Configure here.