feat: add teacher config/sft loss for hosted training SFT#514
Open
feat: add teacher config/sft loss for hosted training SFT#514
Conversation
Add TeacherRolloutModelConfig to the RL config schema so users can specify an external teacher model for SFT hard distill via TOML: [teacher_rollout_model] base_url = ["https://..."] api_key_var = "PRIME_API_KEY" name = "model-name" The field flows through the API client to the platform, which merges it into the orchestrator's run_config as CLI overrides. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5da06aa. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Implements APR-157 SFT distillation support through the existing
prime trainconfig path.loss = "rl" | "sft"with[teacher]and[teacher.sampling]config models.teacher.save = trueis not supported.rollouts_per_exampleto1while preserving explicit overrides.lossandteacher.Training,Teacher, andRun Configrender as separate sections.checkpoint_idare uncommented together.Config Shape
API Payload
{ "loss": "sft", "teacher": { "model": "openai/gpt-oss-120b", "save": false, "sampling": { "max_tokens": 2048, "reasoning_effort": "medium" } } }Tests
uv run pytest packages/prime/tests/test_rl_config.py packages/prime/tests/test_train_cli.py -q