tunnel labels#586
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aaf8ad842d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f4c76f2. Configure here.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38a43935df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee9d151543
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Note
Medium Risk
Expands tunnel API surface (new query/body params for list and bulk delete) and changes CLI deletion behavior to call bulk-delete directly, which could unintentionally delete the wrong tunnels if server-side filtering/scoping differs from expectations.
Overview
Adds tunnel labels end-to-end:
Tunnel/TunnelClient.create_tunnelacceptlabels, andTunnelInfonow includesname,local_port,labels,team_id, and lifecycle timestamps.Extends
TunnelClient.list_tunnelswith filtering/pagination/sorting params and updatesbulk_delete_tunnelsto support deleting bylabelsand scopedteam_id/user_id(with anall_usersguard requiringteam_id).Updates
prime tunnelCLI:startsupports repeated--label;listadds filters + pagination/sort options and optional--output json;stopadds--labeland switches--all/label deletes to call the bulk-delete API with resolved scoping (no pre-listing), including stricter argument validation. Tests added/updated to cover the new request shapes and CLI behaviors.Reviewed by Cursor Bugbot for commit 3fd6130. Bugbot is set up for automated code reviews on this repo. Configure here.