Open
Conversation
Member
|
@codex review |
JannikSt
previously approved these changes
May 4, 2026
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
JannikSt
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prime eval push.timing,token_usage,trajectory, status flags, and state columns throughinfo.avg_*metrics and metadata intact for manually pushedvf-evaloutputs.prime eval runuploads.Validation
uv run pytest packages/prime/tests -quv run ruff check packages/prime/src/prime_cli/commands/evals.py packages/prime/src/prime_cli/utils/eval_push.py packages/prime/tests/test_eval_push.pyuv run ty check packages/prime/src packages/prime/tests/test_eval_push.pyNote
Medium Risk
Changes environment resolution semantics in the Evals SDK and
prime eval push, which could affect how evaluations link to environments and may surface new 404/validation errors for previously auto-created names.Overview
Aligns manual
prime eval pushuploads with automatic verifiers uploads by reusing shared normalization:avg_*metrics are extracted consistently, result samples are normalized (field aliases, timing-derivedtotal_time/latency_ms), and non-standard vf-eval fields are preserved underinfo.Prevents unintended environment creation during evaluation creation/push: the Evals SDK switches name-based environment resolution from
/environmentshub/resolveto lookup-only/environmentshub/lookup, slug lookups useGET /environmentshub/{owner}/{name}/@latest, andcreate_evaluationnow allows dataset-only evaluations (only erroring whenenvironmentsare provided but none resolve). The CLI now treats bare env names as dataset labels and only links environments when an owner slug is provided, while also settingdatasetfrom the pushed env reference.Reviewed by Cursor Bugbot for commit 61cbfdc. Bugbot is set up for automated code reviews on this repo. Configure here.