Skip to content

prime images list pagination#590

Open
kcoopermiller wants to merge 6 commits intomainfrom
fix/imagelistpagination
Open

prime images list pagination#590
kcoopermiller wants to merge 6 commits intomainfrom
fix/imagelistpagination

Conversation

@kcoopermiller
Copy link
Copy Markdown
Member

@kcoopermiller kcoopermiller commented May 2, 2026

Note

Medium Risk
Moderate risk: changes the prime images list API query to always send limit/offset and adds pagination logic, which could affect results/order and relies on backend pagination/totalCount behavior.

Overview
Adds pagination support to prime images list via new --page and --num options, translating them into limit/offset query params on GET /images (with validation and a max of 250 per page).

Updates table-mode output to handle empty pages more explicitly and to show page ranges/next-page hints, using totalCount when present in the API response (while leaving JSON output as the raw response).

Reviewed by Cursor Bugbot for commit 755aabd. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce4822b19c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/prime/src/prime_cli/commands/images.py Outdated
Comment thread packages/prime/src/prime_cli/commands/images.py Outdated
Comment thread packages/prime/src/prime_cli/commands/images.py Outdated
Comment thread packages/prime/src/prime_cli/commands/images.py Outdated
Comment thread packages/prime/src/prime_cli/commands/images.py Outdated
JannikSt
JannikSt previously approved these changes May 2, 2026
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4defa29. Configure here.

Comment thread packages/prime/src/prime_cli/commands/images.py Outdated
@kcoopermiller kcoopermiller requested a review from JannikSt May 2, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants