Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prime eval pushfrom creating uploads against bare local environment names.prime env push <env>and retry with an owner-qualified environment slug before uploading.Validation
uv run pytest packages/prime/tests/test_eval_push.py -quv run pytest packages/prime/tests/test_eval_help.py packages/prime/tests/test_eval_push.py -quv run ruff check packages/prime/src/prime_cli/commands/evals.py packages/prime/tests/test_eval_push.pyuv run ty check packages/prime/src/prime_cli/commands/evals.py packages/prime/tests/test_eval_push.pyNote
Medium Risk
Changes
prime eval pushbehavior to hard-fail when given an unqualified environment name, which may break existing workflows/scripts that relied on local env names.Overview
prime eval pushnow requires a published environment slug (owner/name) when associating an environment with an uploaded evaluation; passing a bare env name triggers a clear error promptingprime env pushand a retry with an owner-qualified slug.CLI help text, examples, and error tips were updated accordingly, and tests were adjusted/added to assert the new enforcement and that the API receives
environments=[{"slug": ...}].Reviewed by Cursor Bugbot for commit 854710b. Bugbot is set up for automated code reviews on this repo. Configure here.