Normalize Whitespace Plugin: add configuration via attributes#3467
Merged
RunDevelopment merged 6 commits intoPrismJS:masterfrom Jun 10, 2022
Merged
Conversation
RunDevelopment
requested changes
Jun 10, 2022
Member
RunDevelopment
left a comment
There was a problem hiding this comment.
Thank you for the PR @plasticrake!
I think the idea is good, but we need to improve the implementation a little.
// value, settingType
assert(t('', 'boolean') === true);
assert(t('true', 'boolean') === true);
assert(t('false', 'boolean') === false);
assert(t('invalid', 'boolean') === undefined);
assert(t('', 'number') === undefined);
assert(t('0', 'number') === 0);
assert(t('123', 'number') === 123);
assert(t('invalid', 'number') === undefined);
assert(t('123invalid456', 'number') === undefined);
Contributor
Author
|
It is more strict parsing data-props. If a value is unexpected it is ignored. Boolean props set with |
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
RunDevelopment
approved these changes
Jun 10, 2022
Member
|
Thank you for contributing @plasticrake! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to set configuration using
data-attributes. Previously you could only set them via page-wide defaults.It appeared there was some unused code with
env.settingsleft over from PR #851. But without that PR/plugin you cannot set anything at the block-level.Original Plugin Author: @zeitgeist87